Update to eslint #583
Merged
Update to eslint #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
update-to-eslint
branch
7 times, most recently
from
3b0a0b8
to
50d1672
Compare
|
Thanks for working on this! |
mixonic
force-pushed
the
update-to-eslint
branch
from
50d1672
to
69ccd13
Compare
mixonic
force-pushed
the
update-to-eslint
branch
from
69ccd13
to
0d80cbf
Compare
mixonic
force-pushed
the
update-to-eslint
branch
from
0d80cbf
to
d67946b
Compare
|
Finally. I could not figure out why the CI suite was crashing Chrome on Travis. It turns out the testem.js config I took from Ember CLI's latest blueprint is incompatible with the version of Testem currently locked as a dependency, and as a result Chrome was not running in a headless mode. I've written a slightly bespoke Testem config that is headless on Travis, which seems sufficient. Onward! |
Gaurav0
reviewed
Mar 28, 2018
| @@ -74,11 +72,15 @@ | |||
| "ember-route-action-helper": "^1.0.0", | |||
| "ember-source": "~2.11.0", | |||
| "ember-test-helpers": "~0.6.3", | |||
| "eslint-plugin-ember": "^5.0.0", | |||
There was a problem hiding this comment.
Please use a ~ with the installed version here. New minor versions of eslint-plugin-ember tend to introduce new rules which cause builds to fail.
|
Canary is broken.
|
|
The PR appears to work locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking a few iterative steps at upgrading the build here, hopefully I can smooth the path for 3.0 support and general contribution.
This PR:
.travis.ymlto be closed to Ember CLI master